lateral tables - basic select, batch insert by JasonShin · Pull Request #236 · JasonShin/sqlx-ts

JasonShin · 2025-11-22T03:33:23Z

First step toward to support JSON query type safety

Copilot

Pull request overview

This PR adds support for PostgreSQL table-valued functions (specifically jsonb_to_recordset) to enable type-safe JSON query handling. The changes implement inference of TypeScript types from column definitions in table function aliases (e.g., AS t(id INT, name TEXT)), allowing for batch insert operations and basic select queries with type safety.

Adds type inference from table-valued function column definitions
Switches from generic SQL dialect to database-specific dialects (PostgreSQL/MySQL)
Changes placeholder type inference from boolean to any for better flexibility

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/postgres_lateral_tables.rs	New test file for validating jsonb_to_recordset select queries with type generation
tests/postgres_batch_insert.rs	New test file for batch insert operations using jsonb_to_recordset
src/ts_generator/types/ts_query.rs	Adds `from_sqlparser_datatype` method and `table_valued_function_columns` storage
src/ts_generator/sql_parser/translate_query.rs	Extracts column definitions from table-valued functions during query translation
src/ts_generator/sql_parser/expressions/translate_expr.rs	Updates identifier resolution to check table-valued functions before database schema
src/ts_generator/sql_parser/expressions/translate_table_with_joins.rs	Extends table name resolution to handle table-valued functions
src/ts_generator/sql_parser/expressions/translate_wildcard_expr.rs	Adds error handling for wildcards with table-valued functions
src/ts_generator/generator.rs	Switches from GenericDialect to database-specific dialects
src/core/connection.rs	Adds `get_db_type` method to DBConn
tests/demo/*	Updates snapshot files reflecting placeholder type change from boolean to any

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-23T03:31:29Z

-          field.is_nullable,
-          expr_for_logging,
-        )?
+        if let Some(field) = table_details.get(&column_name) {


[nitpick] The nested if-let chain (lines 202-217) should use if-let-else chaining or early returns to reduce nesting depth and improve readability.

Copilot · 2025-11-23T03:31:30Z

-            field.is_nullable,
-            expr_for_logging,
-          )?;
+          if let Some(field) = table_details.get(&ident) {


[nitpick] The nested if-let chain (lines 263-292) mirrors the pattern at lines 202-223 with duplicated error messages. Consider extracting this logic into a helper function to reduce duplication.

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-25T23:31:59Z

+  use test_utils::{run_test, sandbox::TestConfig};
+
+  #[rustfmt::skip]
+run_test!(should_support_jsonb_to_recordset_batch_insert, TestConfig::new("postgres", true, None, None),


Test name 'should_support_jsonb_to_recordset_batch_insert' is misleading as this test performs a SELECT query, not a batch insert. Consider renaming to 'should_support_jsonb_to_recordset_select' or similar.

Suggested change

run_test!(should_support_jsonb_to_recordset_batch_insert, TestConfig::new("postgres", true, None, None),

run_test!(should_support_jsonb_to_recordset_select, TestConfig::new("postgres", true, None, None),

Copilot · 2025-11-25T23:32:00Z

+  use test_utils::{run_test, sandbox::TestConfig};
+
+  #[rustfmt::skip]
+run_test!(should_support_jsonb_to_recordset_batch_insert, TestConfig::new("postgres", true, None, None),


Duplicate test name 'should_support_jsonb_to_recordset_batch_insert' exists in both postgres_batch_insert.rs and postgres_lateral_tables.rs, which will cause a compilation error. Each test must have a unique name.

Suggested change

run_test!(should_support_jsonb_to_recordset_batch_insert, TestConfig::new("postgres", true, None, None),

run_test!(should_support_jsonb_to_recordset_batch_insert_postgres, TestConfig::new("postgres", true, None, None),

Copilot · 2025-11-25T23:32:00Z

+          )?
+        } else {
+          error!(
+            "Column '{}' not found in table '{}'. This may be a table-valued function or the column may not exist.",


Error message suggests 'may be a table-valued function' but this code path is only reached after checking table-valued function columns. The message should clarify this is an unexpected scenario, e.g., 'Column not found in table or table-valued function columns'.

Suggested change

"Column '{}' not found in table '{}'. This may be a table-valued function or the column may not exist.",

"Column '{}' not found in table '{}' or table-valued function columns.",

Copilot · 2025-11-25T23:32:00Z

+            )?;
+          } else {
+            error!(
+              "Column '{}' not found in table '{}' for compound identifier '{}.{}'. This may be a table-valued function.",


Similar to previous comment, this error message suggests 'may be a table-valued function' but is reached after checking table-valued function columns. The message should be updated to reflect this is an unexpected condition.

Suggested change

"Column '{}' not found in table '{}' for compound identifier '{}.{}'. This may be a table-valued function.",

"Column '{}' not found in table '{}' for compound identifier '{}.{}'. This is unexpected: column not found in either table-valued function columns or database schema.",

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-30T00:13:37Z

+  for twj in &child_table_with_joins {
+    match &twj.relation {
+      TableFactor::Table {
+        args: Some(table_fn_args),
+        alias,
+        ..
+      } => {
+        // Extract parameters from function arguments
+        for arg in &table_fn_args.args {
+          if let FunctionArg::Unnamed(FunctionArgExpr::Expr(expr))
+          | FunctionArg::Named {
+            arg: FunctionArgExpr::Expr(expr),
+            ..
+          } = arg
+          {
+            // Process the expression to extract any parameters
+            translate_expr(expr, &None, full_table_with_joins, None, ts_query, db_conn, false).await?;
+          }
+        }
+
+        // Extract column definitions from alias if present
+        // e.g., AS t(id INT, name TEXT)
+        if let Some(alias) = alias {
+          let table_name = DisplayTableAlias(alias).to_string();
+          let mut columns = HashMap::new();
+
+          for col_def in &alias.columns {
+            let col_name = DisplayIndent(&col_def.name).to_string();
+            if let Some(data_type) = &col_def.data_type {
+              let ts_type = TsFieldType::from_sqlparser_datatype(data_type);
+              columns.insert(col_name, ts_type);
+            }
+          }
+
+          if !columns.is_empty() {
+            ts_query.table_valued_function_columns.insert(table_name, columns);
+          }
+        }
+      }
+      TableFactor::Function { args, alias, .. } => {
+        // Handle LATERAL functions
+        for arg in args {
+          if let FunctionArg::Unnamed(FunctionArgExpr::Expr(expr))
+          | FunctionArg::Named {
+            arg: FunctionArgExpr::Expr(expr),
+            ..
+          } = arg
+          {
+            translate_expr(expr, &None, full_table_with_joins, None, ts_query, db_conn, false).await?;
+          }
+        }
+
+        // Extract column definitions from LATERAL function alias if present
+        if let Some(alias) = alias {
+          let table_name = DisplayTableAlias(alias).to_string();
+          let mut columns = HashMap::new();
+
+          for col_def in &alias.columns {
+            let col_name = DisplayIndent(&col_def.name).to_string();
+            if let Some(data_type) = &col_def.data_type {
+              let ts_type = TsFieldType::from_sqlparser_datatype(data_type);
+              columns.insert(col_name, ts_type);
+            }
+          }
+
+          if !columns.is_empty() {
+            ts_query.table_valued_function_columns.insert(table_name, columns);
+          }
+        }
+      }
+      _ => {}
+    }
+  }


The logic for extracting column definitions from aliases (lines 68-81 and 98-112) is duplicated. Consider extracting this into a helper function to reduce code duplication.

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

JasonShin changed the title ~~support batch insert~~ support batch insert & handle table valued functions Nov 23, 2025

JasonShin changed the title ~~support batch insert & handle table valued functions~~ lateral tables - basic select, batch insert Nov 23, 2025

JasonShin requested a review from Copilot November 23, 2025 03:30

Copilot AI reviewed Nov 23, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings November 25, 2025 23:31

JasonShin force-pushed the batch-insert branch from 51f396f to 94538ed Compare November 25, 2025 23:31

Copilot AI reviewed Nov 25, 2025

View reviewed changes

JasonShin added 9 commits November 30, 2025 09:12

support batch insert

516b06f

Support batch insert

08a9ee4

add error print

c28ee2b

fmt

b1ac189

default to Boolean if placeholder type cannot be found

f705c01

fix tests

c227ad0

rename tests

ac23a0d

fmt

88191eb

fix postgres lateral test

fdd3420

Copilot AI review requested due to automatic review settings November 30, 2025 00:12

JasonShin force-pushed the batch-insert branch from 9ccce6f to fdd3420 Compare November 30, 2025 00:12

Copilot AI reviewed Nov 30, 2025

View reviewed changes

JasonShin added 2 commits November 30, 2025 09:15

fix single placeholder boolean

33ca7fa

fix

f2dbea3

Copilot AI review requested due to automatic review settings November 30, 2025 00:55

Copilot AI reviewed Nov 30, 2025

View reviewed changes

Comment thread tests/postgres_lateral_tables.rs Outdated

Update tests/postgres_lateral_tables.rs

280fe4b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings November 30, 2025 00:58

Copilot AI reviewed Nov 30, 2025

View reviewed changes

Comment thread tests/postgres_lateral_tables.rs

Comment thread src/ts_generator/sql_parser/translate_query.rs Outdated

Comment thread src/ts_generator/sql_parser/expressions/translate_expr.rs Outdated

Update src/ts_generator/sql_parser/translate_query.rs

89d99b4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings November 30, 2025 01:04

Update src/ts_generator/sql_parser/expressions/translate_expr.rs

e5bb9d9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Nov 30, 2025

View reviewed changes

Comment thread src/ts_generator/sql_parser/expressions/translate_expr.rs

Comment thread src/ts_generator/sql_parser/expressions/translate_expr.rs

JasonShin merged commit a35b7fe into main Nov 30, 2025
33 checks passed

JasonShin deleted the batch-insert branch November 30, 2025 01:31

JasonShin mentioned this pull request Nov 30, 2025

Batch insert? #204

Closed

	run_test!(should_support_jsonb_to_recordset_batch_insert, TestConfig::new("postgres", true, None, None),
	run_test!(should_support_jsonb_to_recordset_select, TestConfig::new("postgres", true, None, None),

	"Column '{}' not found in table '{}'. This may be a table-valued function or the column may not exist.",
	"Column '{}' not found in table '{}' or table-valued function columns.",

	"Column '{}' not found in table '{}' for compound identifier '{}.{}'. This may be a table-valued function.",
	"Column '{}' not found in table '{}' for compound identifier '{}.{}'. This is unexpected: column not found in either table-valued function columns or database schema.",

Conversation

JasonShin commented Nov 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JasonShin commented Nov 22, 2025 •

edited

Loading